Updating solvers module to use arraylias #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanPuzzuoli
force-pushed
the
solvers-arraylias
branch
from
8f6e46f to
45473c3
Compare
DanPuzzuoli
changed the base branch from
main
to
arraylias-integration-branch
DanPuzzuoli
force-pushed
the
solvers-arraylias
branch
2 times, most recently
from
f65437d to
1c6c3ab
Compare
DanPuzzuoli
force-pushed
the
solvers-arraylias
branch
from
1c6c3ab to
4eb6050
Compare
to24toro
suggested changes
Jan 9, 2024
There was a problem hiding this comment.
Thank you, @DanPuzzuoli .
I separated my PR comments from perturbation updatePR.
Plese see if when you have time.
Co-authored-by: Kento Ueda <[email protected]>
Co-authored-by: Kento Ueda <[email protected]>
yes good catch - for now I don't want to fix documentation, I think it should all be fixed at the end when all of the changes have been made (to avoid having to make further unexpected changes). |
to24toro
approved these changes
Jan 19, 2024
DanPuzzuoli
merged commit 4993e00
into
qiskit-community:arraylias-integration-branch
2 checks passed
DanPuzzuoli
added a commit
that referenced
this pull request
Jan 19, 2024
Co-authored-by: Kento Ueda <[email protected]>
DanPuzzuoli
added a commit
that referenced
this pull request
Jan 24, 2024
Co-authored-by: Kento Ueda <[email protected]>
DanPuzzuoli
added a commit
that referenced
this pull request
Feb 5, 2024
Co-authored-by: Kento Ueda <[email protected]>
DanPuzzuoli
added a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Kento Ueda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates all of the
solversfolder to usearraylias, aside from theperturbative_solversfolder, which must be updated after theperturbationfolder.The new release notes describe the material change to the interface:
Solver.__init__now takes argumentsarray_libraryandvectorizedinstead ofevaluation_mode.Solver.solvedecides to automatically JAX compile when simulating a list of schedules has been slightly modified.Details and comments
All of the tests in the following command should be passing: